Review Request: [RFC] Make security widget validations work

[Lamarque Vieira Souza]

> On Aug. 6, 2011, 5:11 p.m., Lamarque Vieira Souza wrote:
> > libs/ui/security/wepwidget.cpp, line 122
> > <http://git.reviewboard.kde.org/r/102157/diff/3/?file=30889#file30889line122>
> >
> >     You could have changed WepWidget::validate() into a slot and used instead of creating a slot that just call WepWidget::validate().
> 
> Rajeesh K Nambiar wrote:
>     validate() is member of superclass SecurityWidget, and returns bool; which is reimplemented by many subclasses, so it wasn't very appealing to change them all.
>     Is there a better way?
> 
> Lamarque Vieira Souza wrote:
>     That is correct way in my point of view. I have just changed SecurityWidget::validate() into a slot it seems to be working, now you just need to use it instead of creating a new slot.
> 
> Rajeesh K Nambiar wrote:
>     Hm, I can't seem to make it work. Emitting valid() from validate() gives compile error "In member function ‘virtual bool WepWidget::validate() const’: error: passing ‘const WepWidget’ as ‘this’ argument of ‘virtual void WepWidget::valid(bool)’ discards qualifiers [-fpermissive]".
>     
>     Furthermore, that would cause infinite loop as valid() is connected to WirelessSecuritySettingWidget::validate() which in turn calls SecurityWidget::validate() again.

Ok, the infinite loop really happens. So I will revert my last commit and you can keep this part as it is.


- Lamarque Vieira


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102157/#review5444
-----------------------------------------------------------


On Aug. 6, 2011, 10:39 a.m., Rajeesh K Nambiar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102157/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2011, 10:39 a.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Summary
> -------
> 
> WEP key validation (should have only 5 to 13 ASCII characters for Ascii key; and 10 to 26 Hex characters for Hex key) wasn't working. Most of the bits were present, here's a gross hack to make it really work. Only implemented and tested WEP validation, but can be extended for other security types as well.
> 
> I'm not sure this could be the best/easiest implementation, spent a night figuring out the right signal/slots :-). If this hack could be refined, please let me know!
> 
> 
> Diffs
> -----
> 
>   libs/ui/security/eapmethodstack.h 552f5c9 
>   libs/ui/security/leapauthwidget.h 3c01e1d 
>   libs/ui/security/nullsecuritywidget.h dc84fb5 
>   libs/ui/security/securityleap.h 402a7af 
>   libs/ui/security/securitywidget.h c536cf6 
>   libs/ui/security/wepauthwidget.h 6ff721b 
>   libs/ui/security/wepwidget.h e78338c 
>   libs/ui/security/wepwidget.cpp f024555 
>   libs/ui/security/wirelesssecuritysettingwidget.cpp fbc2c34 
>   libs/ui/security/wpaauthwidget.h 91e7495 
>   libs/ui/security/wpapskwidget.h 7077836 
> 
> Diff: http://git.reviewboard.kde.org/r/102157/diff
> 
> 
> Testing
> -------
> 
> Tested with WEP Hex and ASCII key validations. "OK" button of connection editor widget is now properly enabled/disabled upon changing key.
> 
> 
> Thanks,
> 
> Rajeesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110807/b2014050/attachment-0001.html>