Review Request: [RFC] Make security widget validations work

[Ilia Kats]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102157/#review5347
-----------------------------------------------------------



libs/ui/security/wepwidget.cpp
<http://git.reviewboard.kde.org/r/102157/#comment4835>

    That's not quite correct. A key can be either hex or ascii, while a passphrase can be anything, the actual key will be derived from the MD5-sum of the passphrase. So the original regex/validator was correct in that part. However, the regexes here specify ranges in length ({5,13} means the thing before that can be repeated from 5 to 13 times), while a hex key can be either 10 or 26, an ascii key either 5 or 13 characters. I think something like (asciiregex{5}|asciiregex{13}|hexregex{10}|hexregex{26}) will do what we want here. Also, the commented out old code should probably be removed completely.


- Ilia


On July 31, 2011, 12:36 p.m., Rajeesh K Nambiar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102157/
> -----------------------------------------------------------
> 
> (Updated July 31, 2011, 12:36 p.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Summary
> -------
> 
> WEP key validation (should have only 5 to 13 ASCII characters for Ascii key; and 10 to 26 Hex characters for Hex key) wasn't working. Most of the bits were present, here's a gross hack to make it really work. Only implemented and tested WEP validation, but can be extended for other security types as well.
> 
> I'm not sure this could be the best/easiest implementation, spent a night figuring out the right signal/slots :-). If this hack could be refined, please let me know!
> 
> 
> Diffs
> -----
> 
>   libs/ui/security/wpapskwidget.h 7077836 
>   libs/ui/security/eapmethodstack.h 552f5c9 
>   libs/ui/security/nullsecuritywidget.h a0faa46 
>   libs/ui/security/securityleap.h 5d9b034 
>   libs/ui/security/securitywidget.h 71ebf4a 
>   libs/ui/security/wepwidget.h e78338c 
>   libs/ui/security/wepwidget.cpp f024555 
>   libs/ui/security/wirelesssecuritysettingwidget.cpp fbc2c34 
> 
> Diff: http://git.reviewboard.kde.org/r/102157/diff
> 
> 
> Testing
> -------
> 
> Tested with WEP Hex and ASCII key validations. "OK" button of connection editor widget is now properly enabled/disabled upon changing key.
> 
> 
> Thanks,
> 
> Rajeesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110803/20da0931/attachment.html>