Review Request: Fix macaddress showing up if not set, introduced with aae4ef730cdd4314be1a7ac043b1be59868b74aa

Ilia Kats ilia-kats at gmx.net
Wed Apr 20 17:43:39 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101161/
-----------------------------------------------------------

Review request for Network Management.


Summary
-------

Resizing the QByteArray gives us 6 uninitialized elements, which can be converted to a string. This results in a completely unrelated mac address showing up on all connection which are restricted to "Any".


Diffs
-----

  libs/internals/settings/802-11-wireless.h 436e219 
  libs/internals/settings/802-3-ethernet.h 9f13796 

Diff: http://git.reviewboard.kde.org/r/101161/diff


Testing
-------


Screenshots
-----------

before
  http://git.reviewboard.kde.org/r/101161/s/133/
after
  http://git.reviewboard.kde.org/r/101161/s/134/


Thanks,

Ilia

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110420/521553be/attachment.htm 


More information about the kde-networkmanager mailing list