Review Request: Add IPv6 support to NetworkManagement

[Lamarque Vieira Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101117/#review2690
-----------------------------------------------------------



solidcontrolfuture/networkipv6config.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2373>

    Remove extra space.



solidcontrolfuture/networkipv6config.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2375>

    You are comparing addresses here, is that what you want? I think the compiler would complaing if you write a code like this:
    
    obj = obj;
    
    or at least it would optimise this by removing this line from the code. I think this line will have no effect since the if will always be false.



solidcontrolfuture/networkipv6config.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2376>

    Comparing addresses.



solidcontrolfuture/networkipv6config.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2374>

    Comparing addresses again here.


- Lamarque Vieira


On April 16, 2011, 9:32 p.m., Ilia Kats wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101117/
> -----------------------------------------------------------
> 
> (Updated April 16, 2011, 9:32 p.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Summary
> -------
> 
> The last IPv4 blocks have been assigned, so IPv6-support in KDE network management is long overdue. Attached patch makes that possible.
> 
> 
> This addresses bug 270827.
>     http://bugs.kde.org/show_bug.cgi?id=270827
> 
> 
> Diffs
> -----
> 
>   backends/NetworkManager/CMakeLists.txt a093415 
>   backends/NetworkManager/connectiondbus.cpp 9c3c908 
>   backends/NetworkManager/settings/ipv4dbus.cpp 7d167e9 
>   backends/NetworkManager/settings/ipv6dbus.h PRE-CREATION 
>   backends/NetworkManager/settings/ipv6dbus.cpp PRE-CREATION 
>   libs/internals/CMakeLists.txt d5a0dab 
>   libs/internals/connection.cpp a5fe2d3 
>   libs/internals/connectionpersistence.cpp cc84af3 
>   libs/internals/schemas/ipv4.kcfg a069ef8 
>   libs/internals/schemas/ipv6.kcfg PRE-CREATION 
>   libs/internals/schemas/ipv6.kcfgc PRE-CREATION 
>   libs/internals/setting.cpp 197fafc 
>   libs/internals/settings/ipv4.h fee2987 
>   libs/internals/settings/ipv4.cpp 6c6fd64 
>   libs/internals/settings/ipv4persistence.cpp c30622d 
>   libs/internals/settings/ipv6.h PRE-CREATION 
>   libs/internals/settings/ipv6.cpp PRE-CREATION 
>   libs/internals/settings/ipv6persistence.h PRE-CREATION 
>   libs/internals/settings/ipv6persistence.cpp PRE-CREATION 
>   libs/ui/CMakeLists.txt aea6563 
>   libs/ui/gsmconnectioneditor.cpp 39e7d3b 
>   libs/ui/ipv4.ui e107869 
>   libs/ui/ipv4widget.cpp 732a94e 
>   libs/ui/ipv6.ui PRE-CREATION 
>   libs/ui/ipv6advanced.ui PRE-CREATION 
>   libs/ui/ipv6advancedwidget.h PRE-CREATION 
>   libs/ui/ipv6advancedwidget.cpp PRE-CREATION 
>   libs/ui/ipv6widget.h PRE-CREATION 
>   libs/ui/ipv6widget.cpp PRE-CREATION 
>   libs/ui/pppoepreferences.cpp be503c0 
>   libs/ui/simpleipv6addressvalidator.h PRE-CREATION 
>   libs/ui/simpleipv6addressvalidator.cpp PRE-CREATION 
>   libs/ui/vpnpreferences.cpp 1714a51 
>   libs/ui/wiredpreferences.cpp 003e05d 
>   libs/ui/wirelesspreferences.cpp 7033c40 
>   solidcontrolfuture/CMakeLists.txt 4643e8d 
>   solidcontrolfuture/networkipv6config.h PRE-CREATION 
>   solidcontrolfuture/networkipv6config.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101117/diff
> 
> 
> Testing
> -------
> 
> Only on my local system, compared qdbus output with nm-applet and knetworkmanager, as well as created ad-hoc wlan connections and checked with ifconfig. My university's network does currently not support IPv6, so a field test could not be done.
> 
> 
> Screenshots
> -----------
> 
> Basic settings
>   http://git.reviewboard.kde.org/r/101117/s/125/
> advanced settings
>   http://git.reviewboard.kde.org/r/101117/s/126/
> 
> 
> Thanks,
> 
> Ilia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110416/ff5f25f4/attachment.html