Review Request: Add IPv6 support to NetworkManagement

Lamarque Vieira Souza lamarque at gmail.com
Thu Apr 14 15:04:07 CEST 2011 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101117/#review2638
-----------------------------------------------------------



backends/NetworkManager/CMakeLists.txt
<http://git.reviewboard.kde.org/r/101117/#comment2301>

    Plese remove this trailing space line. By the way add bug 270827 to this review request.
    
    Patch looks good. Almost all my comments are about text formating. It would be good if someone could text it in a real case.



backends/NetworkManager/connectiondbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2302>

    Remove trailing space.



backends/NetworkManager/settings/ipv6dbus.h
<http://git.reviewboard.kde.org/r/101117/#comment2303>

    Remove trailing space.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2331>

    Remove this line.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2330>

    const QString &key.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2329>

    Remove extra space.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2307>

    Remove extra space.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2304>

    Remove trailing space.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2310>

    Remove extra space.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2311>

    Remove extra space.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2312>

    Remove extra space.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2313>

    Remove extra space.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2314>

    Remove extra space.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2332>

    Remove this line since it is not necessary.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2308>

    Remove extra space.



libs/internals/CMakeLists.txt
<http://git.reviewboard.kde.org/r/101117/#comment2315>

    Remove extra space.



libs/internals/settings/ipv4.h
<http://git.reviewboard.kde.org/r/101117/#comment2309>

    Remove extra space.



libs/internals/settings/ipv6.h
<http://git.reviewboard.kde.org/r/101117/#comment2306>

    Remove extra space.



libs/internals/settings/ipv6persistence.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2333>

    Remove this extra line.



libs/internals/settings/ipv6persistence.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2334>

    Q_UNUSED is used to prevent compiling warnings. Using it in this scope will not prevent any warning.



libs/ui/ipv4widget.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2316>

    Remove extra space.



libs/ui/ipv4widget.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2317>

    Remove extra space.



libs/ui/ipv6advancedwidget.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2326>

    Remove this line since the header is not used.



libs/ui/ipv6widget.h
<http://git.reviewboard.kde.org/r/101117/#comment2327>

    Remove extra line.



libs/ui/ipv6widget.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2325>

    Remove extra space.



libs/ui/ipv6widget.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2328>

    Remove this line since it is not necessary.



libs/ui/ipv6widget.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2318>

    Remove extra space.



libs/ui/ipv6widget.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2319>

    Remove extra space.



libs/ui/ipv6widget.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2320>

    Remove extra space.



libs/ui/simpleipv6addressvalidator.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2321>

    Remove extra space.



libs/ui/simpleipv6addressvalidator.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2322>

    Remove extra space.



solidcontrolfuture/networkipv6config.h
<http://git.reviewboard.kde.org/r/101117/#comment2323>

    Remove extra space.



solidcontrolfuture/networkipv6config.h
<http://git.reviewboard.kde.org/r/101117/#comment2324>

    Remove extra space in this line and the next.


- Lamarque Vieira


On April 13, 2011, 9:46 p.m., Ilia Kats wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101117/
> -----------------------------------------------------------
> 
> (Updated April 13, 2011, 9:46 p.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Summary
> -------
> 
> The last IPv4 blocks have been assigned, so IPv6-support in KDE network management is long overdue. Attached patch makes that possible.
> 
> 
> Diffs
> -----
> 
>   backends/NetworkManager/CMakeLists.txt f6ff372 
>   backends/NetworkManager/connectiondbus.cpp 4a142e9 
>   backends/NetworkManager/settings/ipv4dbus.cpp f77d421 
>   backends/NetworkManager/settings/ipv6dbus.h PRE-CREATION 
>   backends/NetworkManager/settings/ipv6dbus.cpp PRE-CREATION 
>   libs/internals/CMakeLists.txt d5a0dab 
>   libs/internals/connection.cpp 3cd7e78 
>   libs/internals/connectionpersistence.cpp 8396464 
>   libs/internals/schemas/ipv4.kcfg a069ef8 
>   libs/internals/schemas/ipv6.kcfg PRE-CREATION 
>   libs/internals/schemas/ipv6.kcfgc PRE-CREATION 
>   libs/internals/setting.cpp 197fafc 
>   libs/internals/settings/ipv4.h fee2987 
>   libs/internals/settings/ipv4.cpp 6c6fd64 
>   libs/internals/settings/ipv4persistence.cpp c30622d 
>   libs/internals/settings/ipv6.h PRE-CREATION 
>   libs/internals/settings/ipv6.cpp PRE-CREATION 
>   libs/internals/settings/ipv6persistence.h PRE-CREATION 
>   libs/internals/settings/ipv6persistence.cpp PRE-CREATION 
>   libs/ui/CMakeLists.txt aea6563 
>   libs/ui/gsmconnectioneditor.cpp 5a26c7c 
>   libs/ui/ipv4.ui e107869 
>   libs/ui/ipv4widget.cpp 732a94e 
>   libs/ui/ipv6.ui PRE-CREATION 
>   libs/ui/ipv6advanced.ui PRE-CREATION 
>   libs/ui/ipv6advancedwidget.h PRE-CREATION 
>   libs/ui/ipv6advancedwidget.cpp PRE-CREATION 
>   libs/ui/ipv6widget.h PRE-CREATION 
>   libs/ui/ipv6widget.cpp PRE-CREATION 
>   libs/ui/pppoepreferences.cpp 0cabcd0 
>   libs/ui/simpleipv6addressvalidator.h PRE-CREATION 
>   libs/ui/simpleipv6addressvalidator.cpp PRE-CREATION 
>   libs/ui/vpnpreferences.cpp 5274d14 
>   libs/ui/wiredpreferences.cpp 60b7932 
>   libs/ui/wirelesspreferences.cpp 7f901c2 
>   solidcontrolfuture/CMakeLists.txt 4643e8d 
>   solidcontrolfuture/networkipv6config.h PRE-CREATION 
>   solidcontrolfuture/networkipv6config.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101117/diff
> 
> 
> Testing
> -------
> 
> Only on my local system, compared qdbus output with nm-applet and knetworkmanager, as well as created ad-hoc wlan connections and checked with ifconfig. My university's network does currently not support IPv6, so a field test could not be done.
> 
> 
> Screenshots
> -----------
> 
> Basic settings
>   http://git.reviewboard.kde.org/r/101117/s/125/
> advanced settings
>   http://git.reviewboard.kde.org/r/101117/s/126/
> 
> 
> Thanks,
> 
> Ilia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110414/5831eace/attachment-0001.htm

More information about the kde-networkmanager mailing list