Review Request: Delete secrets from wallet when connection is deleted

[Lamarque Vieira Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100975/#review2570
-----------------------------------------------------------



libs/internals/connectionpersistence.h
<http://git.reviewboard.kde.org/r/100975/#comment2248>

    const QString &. After that ship it.


- Lamarque Vieira


On March 30, 2011, 5:37 p.m., Andrey Borzenkov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100975/
> -----------------------------------------------------------
> 
> (Updated March 30, 2011, 5:37 p.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Summary
> -------
> 
> Currently secrets are stuck in wallet forever. This patch adds method to delete them and applies it when connection is deleted. As it touches rather sensitive issues I would like public review.
> 
> Existing remnants still need to be removed manually.
> 
> TODO: ensure plain text secrets are deleted when encrypted storage is configured (is mostly mechanical - set secrets to "" - but touches many files so I'd like to postpone it until systemwide patch is settled)
> 
> TODO: ensure secrets are moved as appropriate when storage type is changed. I am still not sure where to do it.
> 
> 
> Diffs
> -----
> 
>   libs/internals/connectionpersistence.h 26985cbea6ab6e6d38117f931db437177943066a 
>   libs/internals/connectionpersistence.cpp 7c52bb14b5f351fef74328c76bf4a26f3cc8f515 
>   settings/config/manageconnectionwidget.cpp 15a6251f086a679e26eb212697c004de2b532ebd 
> 
> Diff: http://git.reviewboard.kde.org/r/100975/diff
> 
> 
> Testing
> -------
> 
> Tested on top of systemwide and works there. Compile-tested on top of master.
> 
> 
> Thanks,
> 
> Andrey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110412/5157db3a/attachment.htm