Review Request: Fix building networkmanagement due to missing Qt XML library linking

Sebastian Kügler sebas at kde.org
Wed Apr 6 10:52:42 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101014/#review2426
-----------------------------------------------------------

Ship it!


Looks fine.

Out of interest, what kind of system are you building on? I haven't seen this issue before.

- Sebastian


On April 2, 2011, 7:37 p.m., Rajeesh K Nambiar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101014/
> -----------------------------------------------------------
> 
> (Updated April 2, 2011, 7:37 p.m.)
> 
> 
> Review request for Network Management and Lamarque Vieira Souza.
> 
> 
> Summary
> -------
> 
> Commit f2a9e0b6874753 missed explicit linking against libQtXml.so.4 which causes build failures. This patch fixes it.
> 
> 
> This addresses bug 269853.
>     http://bugs.kde.org/show_bug.cgi?id=269853
> 
> 
> Diffs
> -----
> 
>   settings/configshell/CMakeLists.txt fb465eb 
> 
> Diff: http://git.reviewboard.kde.org/r/101014/diff
> 
> 
> Testing
> -------
> 
> Tested by building the RPMs
> 
> 
> Thanks,
> 
> Rajeesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110406/cf7154b2/attachment.htm 


More information about the kde-networkmanager mailing list