Review Request: Hover connection item on interface hover event
Lamarque Souza
lamarque at gmail.com
Fri Sep 3 21:42:05 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5249/
-----------------------------------------------------------
(Updated 2010-09-03 19:42:05.506644)
Review request for Network Management and KNetworkManager.
Changes
-------
Just testing if the e-mail of kde-networkmanager group has been updated in reviewboard.kde.org.
Adding the missing screenshot to test if uploading images is working.
Summary
-------
This patch simulates the hover event on the connection item (right widget) when the interface item (left widget) is hovered. This helps to associate which connection is related to which interface, which is very important when one connection can be used with more than one interface. In the screenshot attached there are two "TIM Web" connections, one related to my 3G modem and another to my cell phone, both connections are valid.
I tried to add a screenshot but reviewboard always reports an error. The screenshot can be accessed here http://www.kde-mg.org/sites/default/files/lamarque/plasma_nm.jpg
This addresses bug 214297.
https://bugs.kde.org/show_bug.cgi?id=214297
Diffs
-----
/trunk/extragear/base/networkmanagement/applet/activatableitem.h 1160089
/trunk/extragear/base/networkmanagement/applet/activatableitem.cpp 1160090
/trunk/extragear/base/networkmanagement/applet/activatablelistwidget.h 1166779
/trunk/extragear/base/networkmanagement/applet/activatablelistwidget.cpp 1166779
/trunk/extragear/base/networkmanagement/applet/interfaceitem.h 1166780
/trunk/extragear/base/networkmanagement/applet/interfaceitem.cpp 1166803
/trunk/extragear/base/networkmanagement/applet/nmpopup.cpp 1171165
Diff: http://svn.reviewboard.kde.org/r/5249/diff
Testing
-------
Screenshots
-----------
http://svn.reviewboard.kde.org/r/5249/s/493/
Thanks,
Lamarque
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20100903/fa75cdb4/attachment.htm
More information about the kde-networkmanager
mailing list