[PATCH 0/5] Framework for allowing mix of permanent and one-time VPN secrets

[Andrey Borzenkov]

On Mon, Nov 29, 2010 at 4:54 PM, Sebastian Kügler <sebas at kde.org> wrote:
> Hi Andrey,
>
> Sorry it took so long (since July!) to get your patches picked up...
>
> On Friday, November 26, 2010 18:19:40 Andrey Borzenkov wrote:
>> Comments are welcome. Thank you!
>
> I've quickly looked over the patches and I don't see anything glaringly wrong.
>

I was mostly concerned about stylistic/architectural issues. The
patches seem do what I intended :)

> That said, I don't use VPN at all myself, so I can't really test them. At the
> same time, Will is "incapacitated" by family illness.
>
> The best for now  is probably if you commit these patches already and we ask
> users for further feedback. If anything turns out to be badly broken, we'll
> fix that =)
>

I think you can link this bug report to it and ask user to test.

https://bugs.kde.org/show_bug.cgi?id=147373

not exactly sure about these two, they seem to describe multiple issues

https://bugs.kde.org/show_bug.cgi?id=188489
https://bugs.kde.org/show_bug.cgi?id=204596

https://bugs.kde.org/show_bug.cgi?id=227418 (it is mine, I opened
another one because it actually covers more than just vpnc plugin; can
be closed as duplicate)

> Andrey, you don't seem to have an SVN account. Should I commit the patches for
> you?

Sure, it will allow me to drop yet another patch to maintain :)

> Cheers, and thanks for looking into this issue,

Thank you for looking at it!