Review Request: Adds Mobile Broadband info to plasma network management (depends on ModemManager patch)

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3778/
-----------------------------------------------------------

(Updated 2010-06-08 02:18:08.750032)


Review request for Network Management and KNetworkManager.


Changes
-------

Shows more information about the 3G device/connection, implemented Mobile 
Broadband signal quality meter. Screenshort updated.


Summary
-------

Adds Mobile Broadband info to plasma applet details window. This patch depends 
on http://reviewboard.kde.org/r/3769/ (Adds preliminary ModemManager support 
to solid).

To test the patch firstly apply http://reviewboard.kde.org/r/3769/ to kdebase-
workspace, recompile solid and then recompile knetworkmanager using this 
patch. You must logout and login again to the changes to take effect. Some 
information are only available when using git NetworkManager and ModemManager 
(May 16, 2010 at least).


Diffs (updated)
-----

  /trunk/kdereview/networkmanagement/applet/CMakeLists.txt 1128263 
  /trunk/kdereview/networkmanagement/applet/activatablelistwidget.cpp 1101380 
  /trunk/kdereview/networkmanagement/applet/gsminterfaceconnectionitem.h PRE-
CREATION 
  /trunk/kdereview/networkmanagement/applet/gsminterfaceconnectionitem.cpp 
PRE-CREATION 
  /trunk/kdereview/networkmanagement/applet/interfacedetailswidget.h 1131036 
  /trunk/kdereview/networkmanagement/applet/interfacedetailswidget.cpp 1131135 
  /trunk/kdereview/networkmanagement/applet/nmpopup.cpp 1131129 
  /trunk/kdereview/networkmanagement/libs/client/CMakeLists.txt 1048694 
  /trunk/kdereview/networkmanagement/libs/client/remoteactivatablelist.cpp 
1107225 
  /trunk/kdereview/networkmanagement/libs/client/remotegsminterfaceconnection.h 
PRE-CREATION 
  /trunk/kdereview/networkmanagement/libs/client/remotegsminterfaceconnection.cpp 
PRE-CREATION 
  /trunk/kdereview/networkmanagement/libs/client/remotegsminterfaceconnection_p.h 
PRE-CREATION 
  /trunk/kdereview/networkmanagement/libs/externals/CMakeLists.txt 1048694 
  /trunk/kdereview/networkmanagement/libs/internals/CMakeLists.txt 1099159 
  /trunk/kdereview/networkmanagement/libs/internals/activatable.h 1048694 
  /trunk/kdereview/networkmanagement/libs/internals/gsminterfaceconnection.h 
PRE-CREATION 
  /trunk/kdereview/networkmanagement/libs/internals/gsminterfaceconnection.cpp 
PRE-CREATION 
  /trunk/kdereview/networkmanagement/libs/internals/gsminterfaceconnectionhelpers.h 
PRE-CREATION 
  /trunk/kdereview/networkmanagement/libs/internals/gsminterfaceconnectionhelpers.cpp 
PRE-CREATION 
  /trunk/kdereview/networkmanagement/libs/internals/gsminterfaceconnectionhelpers_p.h 
PRE-CREATION 
  /trunk/kdereview/networkmanagement/libs/service/CMakeLists.txt 1048694 
  /trunk/kdereview/networkmanagement/libs/service/configurationlauncher.cpp 
1048694 
  /trunk/kdereview/networkmanagement/libs/service/gsmnetworkinterfaceactivatableprovider.h 
PRE-CREATION 
  /trunk/kdereview/networkmanagement/libs/service/gsmnetworkinterfaceactivatableprovider.cpp 
PRE-CREATION 
  /trunk/kdereview/networkmanagement/libs/service/interfaces/org.kde.networkmanagement.gsminterfaceconnection.xml 
PRE-CREATION 
  /trunk/kdereview/networkmanagement/libs/service/networkinterfaceactivatableprovider.h 
1048694 
  /trunk/kdereview/networkmanagement/libs/service/networkinterfacemonitor.cpp 
1048694 
  /trunk/kdereview/networkmanagement/libs/service/sessionabstractedservice.cpp 
1094610 

Diff: http://reviewboard.kde.org/r/3778/diff


Testing
-------


Screenshots
-----------


  http://reviewboard.kde.org/r/3778/s/405/

  http://reviewboard.kde.org/r/3778/s/408/

  http://reviewboard.kde.org/r/3778/s/409/

  http://reviewboard.kde.org/r/3778/s/427/


Thanks,

Lamarque