patch: notify about network connction failure

Timo Hoenig thoenig at suse.de
Tue Jan 9 14:17:25 CET 2007


On Tue, 2007-01-09 at 14:04 +0100, Helmut Schaa wrote:

> Overworked the patch and moved identical code parts from VPN and Network 
> dialog to the base class.

> Helmut

<snip>

> +       if (_dev )
> +       {
> +               if ( _essid.isEmpty() ) {
> +                       desc = i18n("Could not connect to the network using device %1").arg(_dev->getInterface());
> +               } else {
> +                       desc = i18n("Could not connect to the network %1").arg(_essid);
> +               }
> +       }

Why not using something like this:

if (_dev->isWireless ())
    desc = i18n("Could not connect to the network %1").arg(_essid);
else
    desc = i18n("Could not connect to the network using device %1").arg(_dev->getInterface());

<snip>

Other than that the patch looks good to me.

Thanks,

   Timo



More information about the kde-networkmanager mailing list