patch: notify about network connction failure

Helmut Schaa hschaa at suse.de
Tue Jan 9 12:24:21 CET 2007


Hi,

Am Dienstag, 9. Januar 2007 12:10 schrieb Valentine Sinitsyn:
> >> Index: knetworkmanager-notify.h
> >> ===================================================================
> >> --- knetworkmanager-notify.h    (Revision 613233)
> >> +++ knetworkmanager-notify.h    (Arbeitskopie)
> >> @@ -92,6 +92,8 @@
> >>
> >>         public slots:
> >>           void updateActivationStage ();
> >> +         void connectionFailure (QString&, QString& );
>
> TH> If the parameters are not used (yet) we should probably have
> TH> connectionFailure (void) for now and add them only when required.
> Disagree. It's a public slot - it's better to avoid changing
> interface.
> Simple:
> void connectionFailure (QString & = QString:null, QString &  = QString:null
> );

The slot is new, I have put the two parameters only in because I wanted to do 
it the same way as in the VPN dialog. In the VPN dialog the first parameter 
is the reason why VPN failed, the second is a detailed desciption. They both 
come from NM itself. For the network connection we only get the activation 
stage, no reason and no description from NM. So the slot is not used at the 
moment, probably in the future.
Therefor it would be no problem to remove the parameters.

Regards
Helmut



More information about the kde-networkmanager mailing list