patch: notify about network connction failure

Valentine Sinitsyn Valentine.Sinitsyn at usu.ru
Tue Jan 9 12:10:59 CET 2007


Hi all,

>> Index: knetworkmanager-notify.h
>> ===================================================================
>> --- knetworkmanager-notify.h    (Revision 613233)
>> +++ knetworkmanager-notify.h    (Arbeitskopie)
>> @@ -92,6 +92,8 @@
>>  
>>         public slots:
>>           void updateActivationStage ();
>> +         void connectionFailure (QString&, QString& );

TH> If the parameters are not used (yet) we should probably have
TH> connectionFailure (void) for now and add them only when required.
Disagree. It's a public slot - it's better to avoid changing
interface.
Simple:
void connectionFailure (QString & = QString:null, QString &  = QString:null );

would be enough to overcome QString temp("") hack.

Regards,
Valentine



More information about the kde-networkmanager mailing list