[PATCH] Fix a segfault with old config and configure issue

[Robert Buchholz]

Hi,

the attached patches fix some issues I encountered when stressing knm a 
bit.

First, after uninstalling a vpn plugin (but not deleting config entries) 
or tempering with the config, knm would segfault at shutdown because it 
creates a VPNConnection that has no _vpnService set (no .name service 
file found). See [1] for a backtrace and the attached patch for a fix.

Second, the configure script does not respect vpn settings 
like "--without-pptp" because those translate to "$with_pptp=no" for 
autoconf, resulting in the check to succeed (=install pptp).
See the second attached patch for a proposed fix.

Thanks,

Robert

(PS: Sorry if this mail comes through twice, I sent it from a wrong 
     address accidently.)

[1] segfault backtrace
...
#5  0x0000003718188c56 in QString::QString () 
from /usr/qt/3/lib64/libqt-mt.so.3
No symbol table info available.
#6  0x00002abeb7e49ff9 in VPNService::getName (this=<value optimized 
out>) at knetworkmanager-vpn.cpp:483
No locals.
#7  0x00002abeb7e4c6b6 in VPNConnection::save (this=0x5c6400) at 
knetworkmanager-vpn.cpp:292
No locals.
#8  0x00002abeb7e4c75d in ~VPNConnection (this=0x7ffff2cf63e0) at 
knetworkmanager-vpn.cpp:278
No locals.
#9  0x0000003717f34fbf in QObject::~QObject () 
from /usr/qt/3/lib64/libqt-mt.so.3
No symbol table info available.
#10 0x00002abeb7e4a6f2 in ~VPN (this=0x5afc10) at 
knetworkmanager-vpn.cpp:1054
No locals.
#11 0x00002abeb7e23366 in ~KNetworkManager (this=0x7ffff2cf6500) at 
knetworkmanager.cpp:182
No locals.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: knetworkmanager-0.2-only-save-valid-connections.patch
Type: text/x-diff
Size: 347 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-networkmanager/attachments/20070830/bc8866f4/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: knetworkmanager-0.2-configure-respect-no.patch
Type: text/x-diff
Size: 1086 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-networkmanager/attachments/20070830/bc8866f4/attachment-0001.bin