Review Request 130132: Fix no Elapsed nor Remaining time information issue

[Anthony Fieroni]

> On Май 16, 2017, 6:56 преди обяд, Anthony Fieroni wrote:
> > See http://doc.qt.io/qt-5/qdatetime.html#toString toString will do it for you.
> 
> Leslie Zhai wrote:
>     Hi Anthony,
>     
>     But how to covert the Remaining time (for example 233434 ms) to ```toString("HH-mm-ss")``` (for example 00:02:43) by QDateTime? please give me a hint, thanks!
>     
>     Regards,
>     Leslie Zhai
> 
> Anthony Fieroni wrote:
>     QTime().addSecs(elapsed).toString(""hh:mm:ss") even QTime().addSecs(elapsed).toString() http://doc.qt.io/qt-5/qtime.html#toString-1 
>     ```If format is Qt::TextDate, the string format is HH:mm:ss; e.g. 1 second before midnight would be "23:59:59".```
> 
> Leslie Zhai wrote:
>     Hi Anthony,
>     
>     Thanks for your reply!
>     
>     But for Qt5.8.0 the output of QTime().addMSecs(elapsed).toString("hh:mm:ss") or QTime().addSecs(elapsed).toString("hh:mm:ss") is Empty! and QTime().addSecs(elapsed).isValid() is false.
>     
>     perhaps for Qt4.7.0 it is ok https://git.reviewboard.kde.org/r/120459/ I use QTime wrongly? or should I report the bug to Qt UPSTREAM?
>     
>     Regards,
>     Leslie Zhai

Yeah, you are right. QTime::fromMSecsSinceStartOfDay(elapsed).toString() // Note this will wrap if elapsed > 24h, but it should not happen in k3b :)


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130132/#review103215
-----------------------------------------------------------


On Май 16, 2017, 6:20 преди обяд, Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130132/
> -----------------------------------------------------------
> 
> (Updated Май 16, 2017, 6:20 преди обяд)
> 
> 
> Review request for KDE Multimedia, Albert Astals Cid, Anthony Fieroni, and Kai Uwe Broulik.
> 
> 
> Bugs: 379448
>     http://bugs.kde.org/show_bug.cgi?id=379448
> 
> 
> Repository: k3b
> 
> 
> Description
> -------
> 
> Hi KDE developer,
> 
> Cristian reported [such bug](https://bugs.kde.org/show_bug.cgi?id=379448) to me, and I fixed it, but I [can not git push](https://phabricator.kde.org/T6040#94167) now, please review it, if LGTU, please git push on my behalf, thanks a lot!
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -----
> 
>   src/k3bjobprogressdialog.cpp 1091f6c65 
> 
> Diff: https://git.reviewboard.kde.org/r/130132/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20170517/1f8748e2/attachment.htm>