Review Request 130165: Workaround fix Audio CD shows the wrong number of tracks for different tocs

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130165/#review103367
-----------------------------------------------------------




audiocd.cpp (line 129)
<https://git.reviewboard.kde.org/r/130165/#comment68802>

    Yes, not really different, the drives has the exact number of tracks, with each of the tracks starting in the same sector, having the same flags and same bTrack, so why do you think the would be different?


- Albert Astals Cid


On June 22, 2017, 1:44 a.m., Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130165/
> -----------------------------------------------------------
> 
> (Updated June 22, 2017, 1:44 a.m.)
> 
> 
> Review request for KDE Multimedia, Albert Astals Cid, Anthony Fieroni, Harald Sitter, and Xuetian Weng.
> 
> 
> Bugs: 381038
>     http://bugs.kde.org/show_bug.cgi?id=381038
> 
> 
> Repository: audiocd-kio
> 
> 
> Description
> -------
> 
> Dear,
> 
> As pietz described in the bugzilla, audiocd kio slave failed to refresh template titles, so dolphin shows still the number of files from the first CD in the drive, not update the template titles.
> 
> I do not have different CDs right now in my office, but I will borrow some "Music Together" CDs from my little kid :) but I directly read the source code for debugging, although workaround patch is let `tocsAreDifferent` always return true to refresh in force, but what the root cause is? please give me some hints, thanks a lot!
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -----
> 
>   audiocd.cpp 926308d 
> 
> Diff: https://git.reviewboard.kde.org/r/130165/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20170625/f7a8e640/attachment.htm>