Review Request 130165: Why different tocs failed to refresh template titles?

[Leslie Zhai]

> On 六月 22, 2017, 4:19 a.m., Albert Astals Cid wrote:
> > Do you really need to use reviewboard to ask a question?
> > 
> > Seems kind of weird.

Sorry! but please give me some hint, about your implementation of `tocsAreDifferent` it should be enable to work for Qt v4.x, I have no idea why failed to work migrated to KF5, I only applied the workaround patch, not the root cause. thanks!


- Leslie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130165/#review103356
-----------------------------------------------------------


On 六月 21, 2017, 10:30 a.m., Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130165/
> -----------------------------------------------------------
> 
> (Updated 六月 21, 2017, 10:30 a.m.)
> 
> 
> Review request for KDE Multimedia, Albert Astals Cid, Anthony Fieroni, Harald Sitter, and Xuetian Weng.
> 
> 
> Bugs: 381038
>     http://bugs.kde.org/show_bug.cgi?id=381038
> 
> 
> Repository: audiocd-kio
> 
> 
> Description
> -------
> 
> Dear,
> 
> As pietz described in the bugzilla, audiocd kio slave failed to refresh template titles, so dolphin shows still the number of files from the first CD in the drive, not update the template titles.
> 
> I do not have different CDs right now in my office, but I will borrow some "Music Together" CDs from my little kid :) but I directly read the source code for debugging, although workaround patch is let `tocsAreDifferent` always return true to refresh in force, but what the root cause is? please give me some hints, thanks a lot!
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -----
> 
>   audiocd.cpp 926308d 
> 
> Diff: https://git.reviewboard.kde.org/r/130165/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20170622/8a5ed7fb/attachment.htm>