Review Request 130162: Why QDialogButtonBox::Close could not emit closeEvent?

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130162/#review103345
-----------------------------------------------------------




src/k3bsystemproblemdialog.cpp (line 169)
<https://git.reviewboard.kde.org/r/130162/#comment68767>

    `QDialog::done(r);` to defer to the base class, which will hide and do some more magic (`Q_UNUSED` becomes unnecessary then)


- Harald Sitter


On June 19, 2017, 7:58 a.m., Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130162/
> -----------------------------------------------------------
> 
> (Updated June 19, 2017, 7:58 a.m.)
> 
> 
> Review request for KDE Multimedia, Albert Astals Cid and Anthony Fieroni.
> 
> 
> Bugs: 381368
>     http://bugs.kde.org/show_bug.cgi?id=381368
> 
> 
> Repository: k3b
> 
> 
> Description
> -------
> 
> Dear,
> 
> As Dr. Chaptian reported "do not show again" from system configuration problems dialog is not remembered, so I simply added `slotClose` to write the entry for K3b's KConfigGroup. but I have no idea why QDialogButtonBox::Close could not emit closeEvent, not need to connect, perhaps old Qt v4.x was able to work?
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -----
> 
>   src/k3bsystemproblemdialog.h b45f2f80c 
>   src/k3bsystemproblemdialog.cpp 9dfc50c1d 
> 
> Diff: https://git.reviewboard.kde.org/r/130162/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20170619/2da635b2/attachment.htm>