Review Request 130162: Why QDialogButtonBox::Close could not emit closeEvent?

[Leslie Zhai]

> On 六月 19, 2017, 12:01 p.m., Anthony Fieroni wrote:
> > src/k3bsystemproblemdialog.cpp, line 114
> > <https://git.reviewboard.kde.org/r/130162/diff/1/?file=496659#file496659line114>
> >
> >     ```connect(buttonBox->button(QDialogButtonBox::Close), SIGNAL(clicked()), this, SLOT(slotClose()));```
> >     CloseEvent is when you click X in window titlebar, it should work, you can add Q_DECL_OVERRIDE in function declaration to be sure you reimplement right function.

Hi Anthony,

Thanks for your kind response!

I just want to know if without my workaround patch:

```
connect(buttonBox->button(QDialogButtonBox::Close), SIGNAL(clicked()), this, SLOT(slotClose()));
...
```

whether or not it was able to work for old Qt v4.x? because git log src/k3bsystemproblemdialog.cpp it might be work before migrated to kf5.

Regards,
Leslie Zhai


- Leslie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130162/#review103339
-----------------------------------------------------------


On 六月 19, 2017, 11:42 a.m., Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130162/
> -----------------------------------------------------------
> 
> (Updated 六月 19, 2017, 11:42 a.m.)
> 
> 
> Review request for KDE Multimedia, Albert Astals Cid and Anthony Fieroni.
> 
> 
> Bugs: 381368
>     http://bugs.kde.org/show_bug.cgi?id=381368
> 
> 
> Repository: k3b
> 
> 
> Description
> -------
> 
> Dear,
> 
> As Dr. Chaptian reported "do not show again" from system configuration problems dialog is not remembered, so I simply added `slotClose` to write the entry for K3b's KConfigGroup. but I have no idea why QDialogButtonBox::Close could not emit closeEvent, perhaps old Qt v4.x was able to work?
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -----
> 
>   src/k3bsystemproblemdialog.h b45f2f80c 
>   src/k3bsystemproblemdialog.cpp 9dfc50c1d 
> 
> Diff: https://git.reviewboard.kde.org/r/130162/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20170619/8af43f5e/attachment.htm>