Review Request 128998: fix MPRIS DesktopEntry after .desktop file rename

Luigi Toscano luigi.toscano at tiscali.it
Thu Sep 22 10:57:48 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128998/#review99408
-----------------------------------------------------------


Ship it!




Woops, sorry, I missed it when I used grep.
This is the type of changes which should probably go in directly.

- Luigi Toscano


On Sept. 22, 2016, 11:49 a.m., Antonio Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128998/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 11:49 a.m.)
> 
> 
> Review request for KDE Multimedia and Luigi Toscano.
> 
> 
> Repository: juk
> 
> 
> Description
> -------
> 
> The DesktopEntry broadcast by MPRIS needs to match the .desktop file name, otherwise player controls don't work in Plasma taskbar tooltips.
> 
> 
> Diffs
> -----
> 
>   mpris2/mediaplayer2.cpp 34f7ac7 
> 
> Diff: https://git.reviewboard.kde.org/r/128998/diff/
> 
> 
> Testing
> -------
> 
> MPRIS controls work in Plasma taskbar tooltips
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160922/ae9293f0/attachment.htm>


More information about the kde-multimedia mailing list