Review Request 129256: use cmake variables to check if QtDbus is enabled

Takahiro Hashimoto kenya888 at
Tue Oct 25 09:06:10 BST 2016

This is an automatically generated e-mail. To reply, visit:

(Updated 10月 25, 2016, 5:06 p.m.)

Review request for Phonon and Harald Sitter.


update with Sitter's comment

Bugs: 368948

Repository: phonon


Fixes for BUG#368948

QtCore/qfeatures.h is removed on Qt 5.8 branch for moving toward next-gen configure system[1]
Phonon of cource can uses cmake insted of it to handle whether QtDBus is enabled or not easily.
I think it works on both Qt4 and Qt5, but tested on Qt 5.8 branch only.


Diffs (updated)

  phonon/CMakeLists.txt e6dfcb7 
  phonon/ 63f2305 



I've tested to build Phonon with these patterns as following. All cases is with Qt 5.8 branch. More testing by folks is very welcomed:)

1. Build with default option(Phonon DBus and QtDBus enabled) -> build succeeded with DBus support
2. Build with -DPHONON_NO_DBUS=TRUE cmake option -> build succeeded without DBus support
3. Build with default options / without QtDBus installed -> build succeeded without DBus Support.

I checked the file phonon/phonon/phononconfig_p.h generaged correctly by options.


Takahiro Hashimoto

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-multimedia mailing list