Review Request 129401: Don't hard-code CMAKE_VERBOSE_MAKEFILE=OFF

Mon Nov 14 14:22:14 GMT 2016

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129401/#review100835
-----------------------------------------------------------

Ship it!

Ship It!

- Thomas Eschenbacher

On Nov. 14, 2016, 2:01 nachm., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129401/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2016, 2:01 nachm.)
> 
> 
> Review request for KDE Multimedia and Thomas Eschenbacher.
> 
> 
> Repository: kwave
> 
> 
> Description
> -------
> 
> It's IMHO annoying because you can't override it via
> "cmake -DCMAKE_VERBOSE_MAKEFILE=ON". As a source based distro we have
> it enabled by default for cmake based packages in order to more
> easily see what is wrong in case of a build failure.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 1632847 
> 
> Diff: https://git.reviewboard.kde.org/r/129401/diff/
> 
> 
> Testing
> -------
> 
> Passing -DCMAKE_VERBOSE_MAKEFILE now has an effect.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20161114/cd727e53/attachment.htm>