Review Request 126992: Support for ffmpeg 2.9

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126992/#review95930
-----------------------------------------------------------




ffmpegthumbnailer/moviedecoder.h (line 64)
<https://git.reviewboard.kde.org/r/126992/#comment64884>

    snake_case



ffmpegthumbnailer/moviedecoder.h (line 78)
<https://git.reviewboard.kde.org/r/126992/#comment64885>

    snake_case, abbreviations.



ffmpegthumbnailer/moviedecoder.cpp (line 291)
<https://git.reviewboard.kde.org/r/126992/#comment64886>

    m_filter_graph is not initialized properly



ffmpegthumbnailer/moviedecoder.cpp (line 312)
<https://git.reviewboard.kde.org/r/126992/#comment64887>

    please add some comments, why should both inputs and outputs be null here?



ffmpegthumbnailer/moviedecoder.cpp (line 336)
<https://git.reviewboard.kde.org/r/126992/#comment64888>

    use bool returns if you only care about whether the call succeeded.


- Martin Tobias Holmedahl Sandsmark


On Feb. 5, 2016, 10:02 a.m., Maximiliano Curia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126992/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2016, 10:02 a.m.)
> 
> 
> Review request for KDE Multimedia and Torrie Fischer.
> 
> 
> Repository: ffmpegthumbs
> 
> 
> Description
> -------
> 
> This patch should remain compatible with ffmpeg 2.8
> 
> Patch provided by Andreas Cadhalpun <andreas.cadhalpun at googlemail.com> in the
> Debian bug #803813 (https://bugs.debian.org/803813)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 48eed64d76f0542327c8dbce9644e5cc898c8cbc 
>   cmake/FindFFmpeg.cmake 27c6b16de7cfd7514a9a2c273dcd242670248613 
>   ffmpegthumbnailer/moviedecoder.h 288892685b6ae6946f158deacab1eeded5745cb6 
>   ffmpegthumbnailer/moviedecoder.cpp c8ae6d1acd2876cabb5c0594b52f676486be707e 
>   tests/CMakeLists.txt 1728fcdd14b699b8f4d7e9a9ffcd8ddc11f495c6 
> 
> Diff: https://git.reviewboard.kde.org/r/126992/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160527/119de21d/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia