Review Request 118989: KCDDB::Client::lookup() make sure all pending lookup tasks are cleared before starting a new lookup

Frank Schaefer fschaefer.oss at
Fri Jul 29 08:48:33 BST 2016

This is an automatically generated e-mail. To reply, visit:

(Updated July 29, 2016, 7:48 a.m.)


This change has been marked as submitted.

Review request for KDE Multimedia.


Submitted with commit 415a3f7b207de9074cde1701dc71abb1b0336e22 by Leslie Zhai to branch kf5.

Repository: libkcddb


Client::lookup() cancels a pending CDDB lookup and starts a new one.

With musicbrainz5 is enabled always two lookup tasks are queued for a CD data lookup:
one for musicbrainz and another one for freedb.
If the first task fails, the second one is started.

Client::lookup() currently only clears the active lookup task and forgets to clear the queued tasks.
As a result, an old/outdated lookup task (for a previous CD) may be started.


  libkcddb/client.cpp 6ceb0f5 





Frank Schaefer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>
-------------- next part --------------
kde-multimedia mailing list
kde-multimedia at

More information about the kde-multimedia mailing list