Review Request 127065: [Dragon] Analyzer in audio view

Harald Sitter sitter at kde.org
Sun Feb 14 07:55:32 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127065/#review92335
-----------------------------------------------------------



Thanks for the review.

At a glance, it looks good to me. This apparently was introduced in a60f1ace56ae4ccb449ef73bb62df83427cfefbb as part of the KF5 port. I'll do some testing and land this tomorrow.

- Harald Sitter


On Feb. 13, 2016, 6:37 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127065/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2016, 6:37 p.m.)
> 
> 
> Review request for KDE Multimedia, David Edmundson, Lukáš Tinkl, and Harald Sitter.
> 
> 
> Repository: dragon
> 
> 
> Description
> -------
> 
> Analyzer is not initialized.
> 
> 
> Diffs
> -----
> 
>   src/app/audioView2.cpp 98ca473 
> 
> Diff: https://git.reviewboard.kde.org/r/127065/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160214/23f25a0c/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list