Review Request 129673: [recentlyPLayedList] Add keyboard shortcuts

[Harald Sitter]

> On Dec. 23, 2016, 1:24 p.m., Anthony Fieroni wrote:
> > ```
> > [toni at toni-pc dragon]$ rbt post -r 129673 --diff-filename=actions.patch --server https://git.reviewboard.kde.org -p -d --repository=dragon
> > >>> RBTools 0.7.6
> > >>> Python 2.7.12 (default, Jul  3 2016, 21:49:11) 
> > [GCC 5.4.0]
> > >>> Running on Linux-4.8.6-1-x86_64-with-glibc2.2.5
> > >>> Home = /home/toni
> > >>> Current directory = /home/toni/dragon
> > >>> Checking for a Subversion repository...
> > >>> Unable to execute "svn help": skipping SVN
> > >>> Checking for a Git repository...
> > >>> Running: git rev-parse --git-dir
> > >>> Running: git config core.bare
> > >>> Running: git rev-parse --show-toplevel
> > >>> Running: git symbolic-ref -q HEAD
> > >>> Running: git config --get branch.Applications/16.12.merge
> > >>> Running: git config --get branch.Applications/16.12.remote
> > >>> Running: git config --get remote.origin.url
> > >>> repository info: Path: kde:dragon, Base path: , Supports changesets: False
> > >>> Making HTTP GET request to https://git.reviewboard.kde.org/api/
> > >>> Making HTTP GET request to https://git.reviewboard.kde.org/api/validation/diffs/
> > >>> Cached response for HTTP GET https://git.reviewboard.kde.org/api/validation/diffs/ expired and was modified
> > >>> Making HTTP POST request to https://git.reviewboard.kde.org/api/validation/diffs/
> > >>> Got API Error 224 (HTTP code 400): fatal: git cat-file 4fa56180cbd72a9797fc8623f8212a8468a93d2b: bad file
> > 
> > >>> Error data: {u'stat': u'fail', u'err': {u'msg': u'fatal: git cat-file 4fa56180cbd72a9797fc8623f8212a8468a93d2b: bad file\n', u'code': 224}}
> > Traceback (most recent call last):
> >   File "/usr/bin/rbt", line 11, in <module>
> >     load_entry_point('RBTools==0.7.6', 'console_scripts', 'rbt')()
> >   File "/usr/lib/python2.7/site-packages/RBTools-0.7.6-py2.7.egg/rbtools/commands/main.py", line 133, in main
> >     command.run_from_argv([RB_MAIN, command_name] + args)
> >   File "/usr/lib/python2.7/site-packages/RBTools-0.7.6-py2.7.egg/rbtools/commands/__init__.py", line 629, in run_from_argv
> >     exit_code = self.main(*args) or 0
> >   File "/usr/lib/python2.7/site-packages/RBTools-0.7.6-py2.7.egg/rbtools/commands/post.py", line 756, in main
> >     (msg_prefix, e))
> > rbtools.commands.CommandError: Error validating diff
> > 
> > fatal: git cat-file 4fa56180cbd72a9797fc8623f8212a8468a93d2b: bad file
> >  (HTTP 400, API Error 224)
> > ```
> 
> Harald Sitter wrote:
>     Seems more like a client side problem with your dragon repo more than anything. Perhaps try on a new clone.
> 
> Anthony Fieroni wrote:
>     I commit changes to my repo and then make new patches, error happens after first commit, mostly.

I'd suggest instead creating one branch per review and putting everything for that review into that branch. Then use rbt post to let rbt figure out the changes and generate the review diff automatically. Most of the time this will work fine. It's also the preferred workflow once KDE fully switches to phabricator for reviews. If you really want to do patch files tough, you can also upload those manually on the reviewboard webui to generate a new review.

https://community.kde.org/Infrastructure/Review_Board#Using_Review_Board_the_easy_way


- Harald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129673/#review101554
-----------------------------------------------------------


On Dec. 23, 2016, 5:40 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129673/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2016, 5:40 a.m.)
> 
> 
> Review request for KDE Multimedia and Harald Sitter.
> 
> 
> Repository: dragon
> 
> 
> Description
> -------
> 
> Ability to remove item and clear list from keyboard shortcut
> 
> 
> Diffs
> -----
> 
>   src/app/recentlyPlayedList.cpp 2c25e7f 
> 
> Diff: https://git.reviewboard.kde.org/r/129673/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Actions
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/12/20/fad5b9ab-9ffb-4220-a0f4-5a25845c6507__Screenshot_20161220_070541.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20161223/a96462a8/attachment.htm>