Review Request 127741: libkcddb port complete to KF5

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127741/#review95032
-----------------------------------------------------------



Can you please update the patch and not attach a patch?

Also the code is still really wrong in that if. I'm leading to believe you have still not tested it at all, have you?

- Albert Astals Cid


On April 28, 2016, 4:25 a.m., Angelo Scarna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127741/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 4:25 a.m.)
> 
> 
> Review request for KDE Multimedia and Harald Sitter.
> 
> 
> Repository: libkcddb
> 
> 
> Description
> -------
> 
> Port complete to KF5
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a92ff28 
>   kcmcddb/CMakeLists.txt 6cd7822 
>   kcmcddb/cddbconfigwidget.cpp e7e3758 
>   kcmcddb/cddbconfigwidget.ui 16fc911 
>   kcmcddb/doc/CMakeLists.txt a565b0b 
>   kcmcddb/kcmcddb.h 5a9a712 
>   kcmcddb/kcmcddb.cpp 00c8b9f 
>   kcmcddb/libkcddb.desktop d9224bf 
>   libkcddb/CMakeLists.txt 8927d1a 
>   libkcddb/asynccddbplookup.cpp 8cc7d23 
>   libkcddb/asynchttplookup.h 6f3ee4a 
>   libkcddb/asynchttplookup.cpp bba91df 
>   libkcddb/asynchttpsubmit.cpp acc6205 
>   libkcddb/asyncsmtpsubmit.cpp 3ea9702 
>   libkcddb/cache.h 0f67c10 
>   libkcddb/cache.cpp 96c9560 
>   libkcddb/categories.h c2d28fa 
>   libkcddb/categories.cpp 222df47 
>   libkcddb/cddb.h 202f1d9 
>   libkcddb/cddb.cpp 9518f87 
>   libkcddb/cddbplookup.h 6c4244c 
>   libkcddb/cddbplookup.cpp 2f3c772 
>   libkcddb/cdinfo.h 6322f59 
>   libkcddb/cdinfo.cpp ee1cd39 
>   libkcddb/cdinfodialog.h b52773e 
>   libkcddb/cdinfodialog.cpp e7f7839 
>   libkcddb/cdinfodialog.ui 9ca3400 
>   libkcddb/cdinfoencodingwidget.cpp 97f6071 
>   libkcddb/cdinfoencodingwidget.ui 0f92cf7 
>   libkcddb/client.h 136cab7 
>   libkcddb/client.cpp 6ceb0f5 
>   libkcddb/genres.h d0fe2bb 
>   libkcddb/genres.cpp 3af2558 
>   libkcddb/httplookup.h c4861ac 
>   libkcddb/httplookup.cpp 9a43712 
>   libkcddb/httpsubmit.h a37f773 
>   libkcddb/httpsubmit.cpp 402c98d 
>   libkcddb/kcddb.cpp b90873f 
>   libkcddb/kcddb_export.h 6ac6d57 
>   libkcddb/kcddbconfig.cpp 27f2a34 
>   libkcddb/kcddbdebug.h PRE-CREATION 
>   libkcddb/lookup.h 5b5556b 
>   libkcddb/lookup.cpp d3ec89a 
>   libkcddb/musicbrainz/asyncmusicbrainzlookup.h 373fb16 
>   libkcddb/musicbrainz/asyncmusicbrainzlookup.cpp c13c94f 
>   libkcddb/musicbrainz/musicbrainzlookup.h 5f0254f 
>   libkcddb/musicbrainz/musicbrainzlookup.cpp 3364897 
>   libkcddb/sites.h 3a4121b 
>   libkcddb/sites.cpp 65a2e48 
>   libkcddb/smtpsubmit.h 6a082b0 
>   libkcddb/smtpsubmit.cpp 3e74ce9 
>   libkcddb/submit.h e46fedb 
>   libkcddb/submit.cpp 99661cc 
>   libkcddb/synccddbplookup.h f13bcce 
>   libkcddb/synccddbplookup.cpp a4d9625 
>   libkcddb/synchttplookup.h 3c89078 
>   libkcddb/synchttplookup.cpp bfe79d2 
>   libkcddb/synchttpsubmit.cpp 7e13aa7 
>   libkcddb/syncsmtpsubmit.cpp 19cc941 
>   test/CMakeLists.txt e2e2aab 
>   test/asynccddblookuptest.cpp 03f79fe 
>   test/asynchttplookuptest.cpp 3377987 
>   test/asynchttpsubmittest.cpp 155ad98 
>   test/asyncmusicbrainztest.cpp 4aea67e 
>   test/asyncsmtpsubmittest.cpp 5ade7c9 
>   test/cachetest.cpp fd5bcb7 
>   test/cdinfotest.cpp 69f98a8 
>   test/musicbrainztest-fulldate.cpp d1c4ad4 
>   test/musicbrainztest-severaldiscs.cpp e476a8b 
>   test/musicbrainztest.cpp 95bef0b 
>   test/sitestest.cpp dd028fa 
>   test/synccddblookuptest.h 01a750f 
>   test/synccddblookuptest.cpp 6b6b28b 
>   test/synchttplookuptest.cpp c09f324 
>   test/synchttpsubmittest.cpp a107b9d 
>   test/syncsmtpsubmittest.cpp c957c6d 
>   test/utf8test.cpp 83f7b3a 
> 
> Diff: https://git.reviewboard.kde.org/r/127741/diff/
> 
> 
> Testing
> -------
> 
> It has been successfully tested . Now I propose another passage , to bring k3b to KF5
> 
> 
> File Attachments
> ----------------
> 
> fix_cddbconfgiwidget.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/2504817d-eabf-49cc-8697-65b47b267b2a__fix_cddbconfgiwidget.patch
> 
> 
> Thanks,
> 
> Angelo Scarna
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160429/228ff198/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia