Review Request 127704: [Dragon] Hide toolbar on multiscreen setup

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127704/#review94863
-----------------------------------------------------------


Ship it!




:O

This function needs a serious cleanup, the nesting gives me a headache.

Anyway. Patch looks fine.


src/app/fullScreenToolBarHandler.cpp (line 88)
<https://git.reviewboard.kde.org/r/127704/#comment64419>

    I'd drop the qDebug, it serves no real purpose.


- Harald Sitter


On April 21, 2016, 4:59 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127704/
> -----------------------------------------------------------
> 
> (Updated April 21, 2016, 4:59 p.m.)
> 
> 
> Review request for KDE Multimedia and Harald Sitter.
> 
> 
> Bugs: 231157 and 256700
>     http://bugs.kde.org/show_bug.cgi?id=231157
>     http://bugs.kde.org/show_bug.cgi?id=256700
> 
> 
> Repository: dragon
> 
> 
> Description
> -------
> 
> If cursor leaves screen after been on toolbar, it stays shown. We don't need to handle enter event cause mouse event makes that work.
> 
> 
> Diffs
> -----
> 
>   src/app/fullScreenToolBarHandler.cpp 2c0f8d2 
> 
> Diff: https://git.reviewboard.kde.org/r/127704/diff/
> 
> 
> Testing
> -------
> 
> Tested on my multiscreen setup.
> 1. Leave screen when cursor was out toolbar - works.
> 2. Leave screen when cursor was on toolbar - works.
> 3. On one screen - still works.
> 
> 
> File Attachments
> ----------------
> 
> Primary screen with cursor
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/21/46f7fb02-820b-4a20-a769-53497ba9dac3__Screenshot_20160421_194802.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160426/05520017/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia