Review Request 127689: [Dragon] Do not try to resize maximized window

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127689/#review94725
-----------------------------------------------------------


Ship it!




Ah that. Yeah, I think this was initially meant as part of the application design. The application should be as tiny as possibly and as big as necessary. That's why the reason for the resize() calls, they don't make sense when maximised tough. shipit!


src/app/mainWindow.cpp (line 585)
<https://git.reviewboard.kde.org/r/127689/#comment64367>

    For what it's worth. This makes AudioView even more terribly looking. AudioView doesn't lend itself to maximised viewing very well, so this change is rather unfortunate.
    
    Then again, I don't really care about AudioView so I don't care.


- Harald Sitter


On April 20, 2016, 8:19 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127689/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 8:19 a.m.)
> 
> 
> Review request for KDE Multimedia and Harald Sitter.
> 
> 
> Bugs: 355249
>     http://bugs.kde.org/show_bug.cgi?id=355249
> 
> 
> Repository: dragon
> 
> 
> Description
> -------
> 
> This resizes / adjusts looks weird, i plan to remove'm completely
> 
> 
> Diffs
> -----
> 
>   src/app/mainWindow.cpp 4f0b3e0 
>   src/app/videoWindow.cpp 1eb919b 
> 
> Diff: https://git.reviewboard.kde.org/r/127689/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> before
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/20/c5c1a40c-d277-4d33-a7d5-f7040d151aa2__Screenshot_20160420_111344.png
> After
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/04/20/4fa93c3d-5be5-4584-9028-cb7de7e1e68f__Screenshot_20160420_111657.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160420/8f91ecd0/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia