Review Request 127684: [Dragon] MPRIS2 property 'Identity' to match desktop file entry

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127684/#review94702
-----------------------------------------------------------



:O

^^

https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:Identity

"friendly name" in API documentation usually means that the name should be fit for display to a user, as such I think this string needs to be in i18n() instead of QStringLiteral.

I do wonder though. We already have this in the application aboutdata, I think that we should simply fetch it from there instead of hardcoding http://api.kde.org/frameworks-api/frameworks5-apidocs/kcoreaddons/html/classKAboutData.html#afa4023328d0c9a8e2ad203d33e2c046e  ->  http://api.kde.org/frameworks-api/frameworks5-apidocs/kcoreaddons/html/classKAboutData.html#ad286cb17098b6762c39a94e0c2823b88

Ultimately the KAboutData's displayName should be the same as the Name in the desktop file anyway, so you could just use that instead of hardcoding the name yet again.

- Harald Sitter


On April 19, 2016, 3:43 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127684/
> -----------------------------------------------------------
> 
> (Updated April 19, 2016, 3:43 a.m.)
> 
> 
> Review request for KDE Multimedia and Harald Sitter.
> 
> 
> Bugs: 359483
>     http://bugs.kde.org/show_bug.cgi?id=359483
> 
> 
> Repository: dragon
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   src/mpris2/mediaplayer2.cpp b8e4721 
> 
> Diff: https://git.reviewboard.kde.org/r/127684/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160419/414b2102/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia