Review Request 127608: really fix include issues, fix FTBFS against qt-5.6.x

[Rex Dieter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127608/
-----------------------------------------------------------

(Updated April 15, 2016, 10:57 p.m.)


Status
------

This change has been marked as submitted.


Review request for Phonon, Daniel Vrátil, Hrvoje Senjan, and Harald Sitter.


Changes
-------

Submitted with commit 203f62201210b5b4cbb63003c8640d7b4810e4fe by Rex Dieter to branch 4.8.


Repository: phonon


Description
-------

Previous attempts to fixing include issues ends up throwing away all but the first include dir (and so include dir ordering can make success/failure non-deterministic).  As a bonus, add LINK_LIBRARIES "${Qt5Core_LIBRARIES}" in visibility test (else it always fails due to new symbol versioning feature in qt-5.6).

Sorry, this is technically fixing 2 things at once, so I can split it into separate submissions if you prefer.


Diffs
-----

  cmake/FindPhononInternal.cmake 9f6ab40 

Diff: https://git.reviewboard.kde.org/r/127608/diff/


Testing
-------

build succeeds trying to build phonon-qt5 only on rhel7 (previously always fails).


Thanks,

Rex Dieter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160415/013a712a/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia