Review Request 127608: really fix include issues, fix FTBFS against qt-5.6.x

[Harald Sitter]

> On April 8, 2016, 9:30 a.m., Harald Sitter wrote:
> > cmake/FindPhononInternal.cmake, line 412
> > <https://git.reviewboard.kde.org/r/127608/diff/1/?file=455763#file455763line412>
> >
> >     Qt5Core_LIBRARIES wouldn't be defined for qt4 builds, would it?
> 
> Rex Dieter wrote:
>     Correct, so it's essentially a no-op in the Qt4 case
> 
> Harald Sitter wrote:
>     ah uh, I think master solves this already?
>     
>     qt5 on master uses ECM

FWIW, I am about to release master as 4.9, so I am wondering if we still need a shipit on this. if so I'd like hrvojes to give a +1 from his side.

for me it's fine if we land this, but it won't be released (:


- Harald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127608/#review94426
-----------------------------------------------------------


On April 7, 2016, 6:31 p.m., Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127608/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 6:31 p.m.)
> 
> 
> Review request for Phonon, Daniel Vrátil, Hrvoje Senjan, and Harald Sitter.
> 
> 
> Repository: phonon
> 
> 
> Description
> -------
> 
> Previous attempts to fixing include issues ends up throwing away all but the first include dir (and so include dir ordering can make success/failure non-deterministic).  As a bonus, add LINK_LIBRARIES "${Qt5Core_LIBRARIES}" in visibility test (else it always fails due to new symbol versioning feature in qt-5.6).
> 
> Sorry, this is technically fixing 2 things at once, so I can split it into separate submissions if you prefer.
> 
> 
> Diffs
> -----
> 
>   cmake/FindPhononInternal.cmake 9f6ab40 
> 
> Diff: https://git.reviewboard.kde.org/r/127608/diff/
> 
> 
> Testing
> -------
> 
> build succeeds trying to build phonon-qt5 only on rhel7 (previously always fails).
> 
> 
> Thanks,
> 
> Rex Dieter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160415/5e500631/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia