Review Request 125022: Dragonplayer [patch]

Thu Sep 24 20:23:15 BST 2015

> On Септ. 23, 2015, 12:23 след обяд, Harald Sitter wrote:
> > File Attachment: 5.patch - 5.patch
> > <https://git.reviewboard.kde.org/r/125022/#fcomment458>
> >
> >     This is to be done via MPRIS not in dragon player, this change is pretty much not going to get landed ever.
> 
> Anthony Fieroni wrote:
>     Full patch or name of notification?
> 
> Harald Sitter wrote:
>     entire patch
> 
> Anthony Fieroni wrote:
>     Can you make it? I'm not familiar with MPRIS, but this feature is very sensitive when listen radios :)
> 
> Harald Sitter wrote:
>     Dragon is not a music player. The way you'd implement it though is you use the MPRIS api to get changes from any media player (including dragon) and then simply represent that. This could be done via a kded module or a plasma applet. Latter actually exists, but doesn't have notifications (by design I would think).

Yeah, but if i implement in plasma applet, actually i made that, i can't notice when 'real' player send notification and twice code notification appear. Why we connot implement it in src/mpris2/mediaplayer2player.cpp in same way as patch?

> On Септ. 23, 2015, 12:23 след обяд, Harald Sitter wrote:
> > File Attachment: 1.patch - 1.patch
> > <https://git.reviewboard.kde.org/r/125022/#fcomment459>
> >
> >     Firstly what problem are you actually trying to solve here?
> >     
> >     Secondly this looks like a hack. A manually set cursor should reset as closely to where it was set as possible, the proposed change looks a lot like it's not clear which cursor override we are
> >     resetting here.
> 
> Anthony Fieroni wrote:
>     It's not hack. m_cursorTimer is started to hide cursor on fullscreen video playback, when it's fired cursor is hidden, but when playback ends, without manually stop it, no one restore cursor state and he stay invisible.
> 
> Harald Sitter wrote:
>     It restores properly here.
>     
>     - play video
>     - go fullscreen
>     - cursor disappears after timeout
>     - wait for video to stop playing
>     - cursor resets to lefthand
> 
> Anthony Fieroni wrote:
>     Not here. Can you show the piece of code who make it? I sow code very good, no one restore cursor. I don't want to make you lier, but i ca't see code for that.
> 
> Harald Sitter wrote:
>     Ah yes, its broken with phonon gstreamer but works with phonon vlc. What fun. So yeah, what you want to do is restore when the MediaObject enters a non-playback state (i.e. Loading|Paused|Stopped|Error). However the ultimate culprit here is that Lukáš apparently changed the behavior, a video stopping should bring you back to the history view which would be sending all the right events to restore the cursor. Currently it doesn't though.

Gstreamer is away better phonon backend, about me. In last year is twice as better than vlc. Acctualy i use dragon all the time, radio or video playback, and this simple patch work on 100%. It's pity.

- Anthony

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125022/#review85802
-----------------------------------------------------------

On Септ. 24, 2015, 6:11 преди обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125022/
> -----------------------------------------------------------
> 
> (Updated Септ. 24, 2015, 6:11 преди обяд)
> 
> 
> Review request for KDE Multimedia and Lukáš Tinkl.
> 
> 
> Repository: dragon
> 
> 
> Description
> -------
> 
> Dragon fixes
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e2138c5 
>   misc/CMakeLists.txt 5628302 
>   misc/dragonplayer.notifyrc PRE-CREATION 
>   misc/dragonplayerui.rc 38a15c5 
>   src/app/CMakeLists.txt 2696e34 
>   src/app/audioView2.h cc94549 
>   src/app/audioView2.cpp 98ca473 
>   src/app/loadView.h 80eaddb 
>   src/app/loadView.cpp 0ae65ec 
>   src/app/main.cpp 2de3b35 
>   src/app/mainWindow.h bd9ac91 
>   src/app/mainWindow.cpp 777467b 
>   src/app/recentlyPlayedList.h c4d70de 
>   src/app/videoWindow.cpp 552069d 
> 
> Diff: https://git.reviewboard.kde.org/r/125022/diff/
> 
> 
> Testing
> -------
> 
> 1. Restore cursor after fullscreen video ends
> 2. Initialize analyzer on audio streams
> 3. Refresh recently played list after playback is stopped
> 4. Multiple applications support
> 5. Notifications for audio streams
> 
> 
> File Attachments
> ----------------
> 
> 1.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/7b5ffbf3-e5f2-4660-b833-cfca5a1f07ac__1.patch
> 2.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/5c9ee12f-4270-49b9-8612-f165a1e16a78__2.patch
> 3.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/bbb61993-80ff-4dc9-b8e9-6dbc317d429c__3.patch
> 5.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/eb66193f-8c4d-4202-84ad-ec60f3429c0c__5.patch
> 4.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/4578f490-d338-4dd2-9141-e842699da4a0__4.patch
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150924/54994862/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia