Review Request 125022: Dragonplayer [patch]

Anthony Fieroni bvbfan at abv.bg
Tue Sep 22 14:02:14 BST 2015



> On Септ. 20, 2015, 3:29 след обяд, Harald Sitter wrote:
> > I am sorry. I meant whether you could create invidiual review requests per change and perhaps explain the rationale behind the change. Notably I do not see the value in the notification change, that should block the other changes from going in though.

Individual request or patch review for every point? One request for 'restore cursor after fullscreen video ends' and so on?


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125022/#review85685
-----------------------------------------------------------


On Септ. 15, 2015, 7:31 преди обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125022/
> -----------------------------------------------------------
> 
> (Updated Септ. 15, 2015, 7:31 преди обяд)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Repository: dragon
> 
> 
> Description
> -------
> 
> Dragon fixes
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e2138c5 
>   misc/CMakeLists.txt 5628302 
>   misc/dragonplayer.notifyrc PRE-CREATION 
>   misc/dragonplayerui.rc 38a15c5 
>   src/app/CMakeLists.txt 2696e34 
>   src/app/audioView2.h cc94549 
>   src/app/audioView2.cpp 98ca473 
>   src/app/loadView.h 80eaddb 
>   src/app/loadView.cpp 0ae65ec 
>   src/app/main.cpp 2de3b35 
>   src/app/mainWindow.h bd9ac91 
>   src/app/mainWindow.cpp 777467b 
>   src/app/recentlyPlayedList.h c4d70de 
>   src/app/videoWindow.cpp 552069d 
> 
> Diff: https://git.reviewboard.kde.org/r/125022/diff/
> 
> 
> Testing
> -------
> 
> 1. Restore cursor after fullscreen video ends
> 2. Initialize analyzer on audio streams
> 3. Refresh recently played list after playback is stopped
> 4. Multiple applications support
> 5. Notifications for audio streams
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150922/e67a2859/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list