Review Request 125022: Dragonplayer [patch]

[Anthony Fieroni]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125022/#review85413
-----------------------------------------------------------



misc/CMakeLists.txt (line 8)
<https://git.reviewboard.kde.org/r/125022/#comment59008>

    Install new file for plasma notifications.



misc/dragonplayer.notifyrc (line 1)
<https://git.reviewboard.kde.org/r/125022/#comment59007>

    New file for plasma notifications.



misc/dragonplayerui.rc (line 27)
<https://git.reviewboard.kde.org/r/125022/#comment59006>

    Option in settings menu.



src/app/audioView2.h (line 25)
<https://git.reviewboard.kde.org/r/125022/#comment59005>

    Need for notifications.



src/app/audioView2.cpp (line 36)
<https://git.reviewboard.kde.org/r/125022/#comment59004>

    Load analyzer on audio streams.



src/app/audioView2.cpp (line 55)
<https://git.reviewboard.kde.org/r/125022/#comment59003>

    Slot for notifications.



src/app/loadView.cpp (line 42)
<https://git.reviewboard.kde.org/r/125022/#comment59002>

    Used to notify recently played object to read again configurtion for new entries.



src/app/main.cpp (line 68)
<https://git.reviewboard.kde.org/r/125022/#comment59000>

    Read configuration in KDE section "MultipleInstances".



src/app/main.cpp (line 70)
<https://git.reviewboard.kde.org/r/125022/#comment59001>

    Make dbus service unique/multiple depend on readed config.



src/app/mainWindow.cpp 
<https://git.reviewboard.kde.org/r/125022/#comment58999>

    Solid/Power api not present in kf 5.13 and kf 5.14 to port it.



src/app/mainWindow.cpp (line 344)
<https://git.reviewboard.kde.org/r/125022/#comment58995>

    Add action for notifications.



src/app/mainWindow.cpp (line 349)
<https://git.reviewboard.kde.org/r/125022/#comment58996>

    Read configuration under KDE section "Notifications"



src/app/mainWindow.cpp (line 352)
<https://git.reviewboard.kde.org/r/125022/#comment58997>

    Call to activate notifications on start up, if entry is true.



src/app/mainWindow.cpp (line 404)
<https://git.reviewboard.kde.org/r/125022/#comment58992>

    Slot when notification in settings is clicked.



src/app/mainWindow.cpp (line 407)
<https://git.reviewboard.kde.org/r/125022/#comment58998>

    Store configuration.



src/app/mainWindow.cpp (line 410)
<https://git.reviewboard.kde.org/r/125022/#comment58993>

    Assign phonon metadata changes signal to audioview slot for notification.



src/app/mainWindow.cpp (line 412)
<https://git.reviewboard.kde.org/r/125022/#comment58994>

    Disconnect if user do not want notifications



src/app/mainWindow.cpp (line 468)
<https://git.reviewboard.kde.org/r/125022/#comment58990>

    Before show recently played list, update it with last playback, who is updated in stateChange.cpp:121 MainWindow::engineMediaChanged.



src/app/mainWindow.cpp (line 474)
<https://git.reviewboard.kde.org/r/125022/#comment58991>

    Before show recently played list, update it with last playback, who is updated in stateChange.cpp:121 MainWindow::engineMediaChanged.



src/app/recentlyPlayedList.h (line 33)
<https://git.reviewboard.kde.org/r/125022/#comment58989>

    Make it public to use it in loadView.



src/app/videoWindow.cpp (line 729)
<https://git.reviewboard.kde.org/r/125022/#comment58988>

    When goes to fullscreen video cursor is hidden by m_cursorTimer. When fullscreen video ends on QEvent::Leave is needed to restore cursor state not only to stop cursorTimer.


- Anthony Fieroni


On Септ. 14, 2015, 8:59 след обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125022/
> -----------------------------------------------------------
> 
> (Updated Септ. 14, 2015, 8:59 след обяд)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Repository: dragon
> 
> 
> Description
> -------
> 
> Dragon fixes
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e2138c5 
>   misc/CMakeLists.txt 5628302 
>   misc/dragonplayer.notifyrc PRE-CREATION 
>   misc/dragonplayerui.rc 38a15c5 
>   src/app/CMakeLists.txt 2696e34 
>   src/app/audioView2.h cc94549 
>   src/app/audioView2.cpp 98ca473 
>   src/app/loadView.h 80eaddb 
>   src/app/loadView.cpp 0ae65ec 
>   src/app/main.cpp 2de3b35 
>   src/app/mainWindow.h bd9ac91 
>   src/app/mainWindow.cpp 777467b 
>   src/app/recentlyPlayedList.h c4d70de 
>   src/app/videoWindow.cpp 552069d 
> 
> Diff: https://git.reviewboard.kde.org/r/125022/diff/
> 
> 
> Testing
> -------
> 
> 1. Restore cursor after fullscreen video ends
> 2. Initialize analyzer on audio streams
> 3. Refresh recently played list after playback is stopped
> 4. Multiple applications support
> 5. Notifications for audio streams
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150915/f350c18a/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia