Review Request 124999: Enable build of the X11 render if X11 can be found

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124999/#review84808
-----------------------------------------------------------


Thanks, that looks good! Just drop the include_directories, I don't think that's necessary now (they should get added automatically when you link against Qt5::X11Extras target).


CMakeLists.txt (line 56)
<https://git.reviewboard.kde.org/r/124999/#comment58691>

    This should not be necessary


- Daniel Vrátil


On Sept. 3, 2015, 10:19 p.m., Samuel Gaist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124999/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2015, 10:19 p.m.)
> 
> 
> Review request for Phonon and Daniel Vrátil.
> 
> 
> Repository: phonon-gstreamer
> 
> 
> Description
> -------
> 
> Rather than build on all non WIN32 OS, search for X11 and enable
> the build of the renderer if it's available.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e601ec64710b29408ce5a5be1ad4da281b5007f9 
>   gstreamer/CMakeLists.txt 60bfcb9a73952856f7d6617fc63328e7b600d7cb 
>   gstreamer/devicemanager.cpp 89d408861da8b6bb598c44b28e7c58dccdf6df53 
> 
> Diff: https://git.reviewboard.kde.org/r/124999/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150904/af624986/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia