Review Request 124999: Enable build of the X11 render if X11 can be found

[Daniel Vrátil]

> On Sept. 2, 2015, 12:20 a.m., Daniel Vrátil wrote:
> > CMakeLists.txt, line 52
> > <https://git.reviewboard.kde.org/r/124999/diff/1/?file=399710#file399710line52>
> >
> >     How about looking for QtX11Extras, then turning the feature of at build time when QtX11Extras is not present, and turning it off at runtime when QtX11Extras is present, but we are not running X11 session (using `QX11Info::isPlatformX11()`)?
> 
> Samuel Gaist wrote:
>     Maybe a silly question but are we sure that the module will be available on all supported platforms using X11 ? If so yes, that's a good idea

We don't have to be sure, this is downstream packager problem: when packager gets "Mission optional dependency: QtX11Extras", they either say "well, we are on Windows/Wayland only/.../..., we don't care", thus the feature is disabled at build time, or they say "doh, I need to add QtX11Extras to dependencies to make it work on X11 too", thus the feature is enabled at buildtime, but optionally disabled at runtime when user actually runs it on Wayland. This means that we always have it on system that *wants* to support X11, and optionally on system that *can* support X11. If not then it's downstream packaging issue and we basically don't care.


Now the completely different question is whether phonon-gstreamer actually works on Wayland, something that nobody actually ever tried...:-)


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124999/#review84731
-----------------------------------------------------------


On Sept. 1, 2015, 10:05 p.m., Samuel Gaist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124999/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2015, 10:05 p.m.)
> 
> 
> Review request for Phonon and Daniel Vrátil.
> 
> 
> Repository: phonon-gstreamer
> 
> 
> Description
> -------
> 
> Rather than build on all non WIN32 OS, search for X11 and enable
> the build of the renderer if it's available.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e601ec64710b29408ce5a5be1ad4da281b5007f9 
>   gstreamer/CMakeLists.txt 60bfcb9a73952856f7d6617fc63328e7b600d7cb 
> 
> Diff: https://git.reviewboard.kde.org/r/124999/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150902/a98d12a7/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia