Review Request 125541: phonon-gstreamer gst/gstconfig.h missing include path
Rex Dieter
rdieter at gmail.com
Mon Oct 19 14:24:35 BST 2015
> On Oct. 10, 2015, 10:45 a.m., Rex Dieter wrote:
> > Please fix this new warning, then I think we have a winner.
> >
> > CMake Warning (dev) at CMakeLists.txt:37 (find_package):
> > A logical block opening on the line
> >
> > /home/rdieter1/git.kde.org/phonon-gstreamer/cmake/FindGStreamer.cmake:16 (IF)
> >
> > closes on the line
> >
> > /home/rdieter1/git.kde.org/phonon-gstreamer/cmake/FindGStreamer.cmake:21 (ENDIF)
> >
> > with mis-matching arguments.
Looks like this is no longer needed, another review took care of this issue, https://git.reviewboard.kde.org/r/125690/
- Rex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125541/#review86618
-----------------------------------------------------------
On Oct. 8, 2015, 2:43 p.m., Luca Sartorelli wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125541/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 2:43 p.m.)
>
>
> Review request for Phonon and Phonon Backends.
>
>
> Repository: phonon-gstreamer
>
>
> Description
> -------
>
> phonon-gstreamer doesn't build due to missing include path for gst/gstconfig.h, that my debian sid machine it's located inside the gstreamer library directory.
>
>
> Diffs
> -----
>
> cmake/FindGStreamer.cmake d7243d4
>
> Diff: https://git.reviewboard.kde.org/r/125541/diff/
>
>
> Testing
> -------
>
> phonon-gstreamer build properly
>
>
> File Attachments
> ----------------
>
> CMakeLists.txt
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/08/e5ef6ee5-0ed6-468f-899f-5e3c9290afcb__CMakeLists.txt.patch
> FindGStreamer.cmake
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/08/39135f1d-65ab-4e2f-8bf8-b2d9d0c86fcc__FindGStreamer.cmake.patch
>
>
> Thanks,
>
> Luca Sartorelli
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20151019/ed51c0f4/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
More information about the kde-multimedia
mailing list