Review Request 125690: Fix finding recent versions of GStreamer.

Daniel Vrátil dvratil at kde.org
Sun Oct 18 19:40:55 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125690/#review87029
-----------------------------------------------------------

Ship it!


Looks good.

- Daniel Vrátil


On Oct. 18, 2015, 4:25 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125690/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2015, 4:25 p.m.)
> 
> 
> Review request for Phonon and Daniel Vrátil.
> 
> 
> Repository: phonon-gstreamer
> 
> 
> Description
> -------
> 
> Fix finding recent versions of GStreamer.
> 
> Newer versions of GStreamer put gst-config.h under lib/gstreamer-1.0/include, so we need to make sure that directory will be added to the include path as well.
> 
> 
> Diffs
> -----
> 
>   cmake/FindGStreamer.cmake d7243d4c1b86d38ba27b3350f0460f29eb563ba7 
> 
> Diff: https://git.reviewboard.kde.org/r/125690/diff/
> 
> 
> Testing
> -------
> 
> Builds with GStreamer-1.6.0 on ArchLinux.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20151018/d236b32e/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list