Review Request 125591: Refactor X11 detection to be compatible with Qt 4 and Qt 5

[Samuel Gaist]

> On Oct. 12, 2015, 1:07 p.m., Daniel Vrátil wrote:
> > gstreamer/CMakeLists.txt, line 107
> > <https://git.reviewboard.kde.org/r/125591/diff/1/?file=410553#file410553line107>
> >
> >     Why remove this? Without linking against Qt5::X11Extras this won't compile on Qt5, because we are calling `QX11Info::isPlatformX11()` from the code.

Sorry, that was accidental


- Samuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125591/#review86715
-----------------------------------------------------------


On Oct. 10, 2015, 9:15 p.m., Samuel Gaist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125591/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2015, 9:15 p.m.)
> 
> 
> Review request for Phonon and Daniel Vrátil.
> 
> 
> Repository: phonon-gstreamer
> 
> 
> Description
> -------
> 
> Refactor X11 detection to be compatible with Qt 4 and Qt 5
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d9884956e67a7e9e6e73aacf965a5a3f9a805309 
>   gstreamer/CMakeLists.txt 60ffd5c9f97bb51c9335574a874baf515f515e03 
>   gstreamer/devicemanager.cpp bc1689a998a20182af86357c92a2d6811ccc9577 
> 
> Diff: https://git.reviewboard.kde.org/r/125591/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20151017/3fa690c8/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia