Review Request 125022: Dragonplayer [patch]

[Anthony Fieroni]

> On Септ. 23, 2015, 12:23 след обяд, Harald Sitter wrote:
> > File Attachment: 5.patch - 5.patch
> > <https://git.reviewboard.kde.org/r/125022/#fcomment485>
> >
> >     This is to be done via MPRIS not in dragon player, this change is pretty much not going to get landed ever.
> 
> Anthony Fieroni wrote:
>     Full patch or name of notification?
> 
> Harald Sitter wrote:
>     entire patch
> 
> Anthony Fieroni wrote:
>     Can you make it? I'm not familiar with MPRIS, but this feature is very sensitive when listen radios :)
> 
> Harald Sitter wrote:
>     Dragon is not a music player. The way you'd implement it though is you use the MPRIS api to get changes from any media player (including dragon) and then simply represent that. This could be done via a kded module or a plasma applet. Latter actually exists, but doesn't have notifications (by design I would think).
> 
> Anthony Fieroni wrote:
>     Yeah, but if i implement in plasma applet, actually i made that, i can't notice when 'real' player send notification and twice code notification appear. Why we connot implement it in src/mpris2/mediaplayer2player.cpp in same way as patch?
> 
> Harald Sitter wrote:
>     Because dragon will not ever get an OSD. An OSD is only useful with audio and there even only with radio streams (what with dragon not having a playlist), and since dragon is not meant to be an audio player there is no place for an OSD.
>     
>     You can make a plasmoid or kded module dedicated for dragon to show the notification. MPRIS2 allows you to differentiate players http://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:DesktopEntry

15.08.2 is on the way, no changes present, just bump version. I make these patches not to waste time, to make this software better.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125022/#review85802
-----------------------------------------------------------


On Окт. 7, 2015, 9:58 след обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125022/
> -----------------------------------------------------------
> 
> (Updated Окт. 7, 2015, 9:58 след обяд)
> 
> 
> Review request for KDE Multimedia and Lukáš Tinkl.
> 
> 
> Repository: dragon
> 
> 
> Description
> -------
> 
> Dragon fixes
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e2138c5 
>   misc/CMakeLists.txt 5628302 
>   misc/dragonplayer.notifyrc PRE-CREATION 
>   misc/dragonplayerui.rc 38a15c5 
>   src/app/CMakeLists.txt 2696e34 
>   src/app/audioView2.h cc94549 
>   src/app/audioView2.cpp 98ca473 
>   src/app/loadView.h 80eaddb 
>   src/app/loadView.cpp 0ae65ec 
>   src/app/main.cpp 2de3b35 
>   src/app/mainWindow.h bd9ac91 
>   src/app/mainWindow.cpp 777467b 
>   src/app/recentlyPlayedList.h c4d70de 
>   src/app/videoWindow.cpp 552069d 
> 
> Diff: https://git.reviewboard.kde.org/r/125022/diff/
> 
> 
> Testing
> -------
> 
> 1. Restore cursor after fullscreen video ends
> 2. Initialize analyzer on audio streams
> 3. Refresh recently played list after playback is stopped
> 4. Multiple applications support
> 5. Notifications for audio streams
> 
> 
> File Attachments
> ----------------
> 
> 1.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/7b5ffbf3-e5f2-4660-b833-cfca5a1f07ac__1.patch
> 2.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/5c9ee12f-4270-49b9-8612-f165a1e16a78__2.patch
> 3.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/bbb61993-80ff-4dc9-b8e9-6dbc317d429c__3.patch
> 5.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/eb66193f-8c4d-4202-84ad-ec60f3429c0c__5.patch
> 4.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/23/4578f490-d338-4dd2-9141-e842699da4a0__4.patch
> 5.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/07/4ad4a5ac-184f-43f3-8e5d-5e88784cc3c4__patch5
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20151011/434f5a10/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia