Review Request 125541: phonon-gstreamer gst/gstconfig.h missing include path

[Rex Dieter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125541/#review86503
-----------------------------------------------------------


I'd recommend an approach similar to how it was done in telepathy-qt, http://cgit.freedesktop.org/telepathy/telepathy-qt/commit/?id=ec4a3d62b68a57254515f01fc5ea3325ffb1dbfb

Using pkg-config hints instead...

- Rex Dieter


On Oct. 6, 2015, 1:16 p.m., Luca Sartorelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125541/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 1:16 p.m.)
> 
> 
> Review request for Phonon and Phonon Backends.
> 
> 
> Repository: phonon-gstreamer
> 
> 
> Description
> -------
> 
> phonon-gstreamer doesn't build due to missing include path for gst/gstconfig.h, that my debian sid machine it's located inside the gstreamer library directory.
> 
> 
> Diffs
> -----
> 
>   cmake/FindGStreamer.cmake d7243d4 
> 
> Diff: https://git.reviewboard.kde.org/r/125541/diff/
> 
> 
> Testing
> -------
> 
> phonon-gstreamer build properly
> 
> 
> File Attachments
> ----------------
> 
> CMakeLists.txt
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/06/4347eca1-739b-4891-b1a6-3d028744f1bd__CMakeLists.txt.patch
> FindGStreamer.cmake
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/06/1f671727-9d3c-40f2-a8d9-e6cb684bbc5f__FindGStreamer.cmake.patch
> 
> 
> Thanks,
> 
> Luca Sartorelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20151008/1c08a770/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia