Review Request 123874: Fix build with Qt >= 5.4.2

[Harald Sitter]

On Mon, May 25, 2015 at 7:41 PM, Thiago Macieira <thiago at kde.org> wrote:
> On Monday 25 May 2015 15:51:11 Hrvoje Senjan wrote:
>> > On May 25, 2015, 12:34 p.m., Alex Merry wrote:
>> > > Linking against the QtCore target should bring in any flags necessary to
>> > > make that link succeed. If it doesn't, that's a problem with Qt's CMake
>> > > targets.
>> > >
>> > > Thiago's email to the list suggested that had been resolved in the 5.4.2
>> > > branch. Could you check that and confirm, please?
>> No it is not resolved for *this* case. Linking to Qt5Core works fine.
>> Trouble is with check_qt_visibility.cpp: ```
>> #include <QtCore/QtGlobal>
>>  int main()
>>  {
>>  #ifndef QT_VISIBILITY_AVAILABLE
>>  #error QT_VISIBILITY_AVAILABLE is not available
>>  #endif
>>  }
>> ```
>> and try_compile is called only with ${_include_dirs}
>
> You can solve this problem by making this test "true".
>
> Qt cannot be built without visibility anymore. Just accept that it works and
> remove the test.

Phonon supports ever so ancient Qt4 versions, so I am not sure that is
the best course of action.

HS
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia