Review Request 123121: Adding a tooltip to VolumeSlider

Ronnie Thomas ronnietom at gmail.com
Wed Mar 25 09:05:55 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123121/
-----------------------------------------------------------

(Updated March 25, 2015, 9:05 a.m.)


Review request for KDE Multimedia.


Changes
-------

Fixed position of tooltip in the horizontal orientation. Also altered size of the tooltip.


Bugs: 320949
    http://bugs.kde.org/show_bug.cgi?id=320949


Repository: kmix


Description
-------

This patch adds a tooltip to the VolumeSlider, which shows the current value of the slider in percentage. The tooltip is shown only when the slider handle is selected, and it changes its value dynamically when the slider is moved from its current position.
Possible implementation of bug 320949.


Diffs (updated)
-----

  gui/volumeslider.h 616c9a0 
  gui/volumeslider.cpp 1a4166e 

Diff: https://git.reviewboard.kde.org/r/123121/diff/


Testing
-------

Tested for both horizontal and vertical orientation of the slider.


Thanks,

Ronnie Thomas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150325/4cbfa2a3/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list