Review Request 123052: fix setting a schemeless absolute url as a source not working

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123052/#review77745
-----------------------------------------------------------

Ship it!


Ship It!

- Harald Sitter


On March 19, 2015, 4:01 p.m., Anthony Vital wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123052/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 4:01 p.m.)
> 
> 
> Review request for Phonon.
> 
> 
> Bugs: 341585
>     http://bugs.kde.org/show_bug.cgi?id=341585
> 
> 
> Repository: phonon-vlc
> 
> 
> Description
> -------
> 
> QUrl considers url.scheme.isEmpty() == url.isRelative(), so to be sure the url is not actually absolute we just check the first character.
> (FYI, the same thing is done in KNotifyConfig)
> 
> 
> Diffs
> -----
> 
>   src/mediaobject.cpp 5329b24a4ed578ecd03d6e5a36230ce89fe65b57 
> 
> Diff: https://git.reviewboard.kde.org/r/123052/diff/
> 
> 
> Testing
> -------
> 
> In kcmnotify (see bug #341585), tried with relative, absolute and scheme+absolute paths. Worked fine.
> Same with a home made phonon application.
> 
> 
> Thanks,
> 
> Anthony Vital
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150319/f0a70539/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia