Two branches for KMix?
Alexander Potashev
aspotashev at gmail.com
Wed Jul 1 21:27:38 BST 2015
2015-05-21 14:56 GMT+03:00 Alexander Potashev <aspotashev at gmail.com>:
> Hi everyone,
>
> I don't understand why doesn't KMix use the common approach with two
> branches - "master" and "frameworks"? There is instead a CMake switch
> to build the KF5 version.
>
> IMO, this is harder to maintain and I suggest that a "frameworks" is
> created and both branches be free of "#ifdef X_KMIX_KF5_BUILD"
> constructs.
>
>
> Why do I bother? Because I was going to push a little patch regarding
> localization of KF5 version and it was hard to decide if it should be
> guarded with ifdef X_KMIX_KF5_BUILD. If we had two branches, I would
> simply push to "frameworks" and leave "master" alone without need to
> test the second time against KDELibs4.
Hi,
Looks like nobody actively objects to splitting KMix into two
branches, so I'll do it now:
- Branch "master" will contain KDELibs4-based code for now,
- Branch "frameworks" will contain KF5-based code.
P.S. I also heard of kde:scratch/sitter/plasma-volume-control.git,
but it doesn't replace KMix because it's a QML applet for Plasma, so
you can't use it if Plasma Workspace is not running.
--
Alexander Potashev
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
More information about the kde-multimedia
mailing list