Review Request 121166: Add some space over device icons, otherwise they may hit window border

Christian Esken esken at kde.org
Tue Jan 20 19:49:19 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121166/#review74424
-----------------------------------------------------------

Ship it!


Thanks for the patch, Andrey. The patch seems fine. I also do not see degration in any of the styles I use.
I am currently doing a start-of-year swipe of tickets and reviewboard for KMix. I will apply your patch soon.

- Christian Esken


On Nov. 18, 2014, 4:24 p.m., Andrey Bondrov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121166/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2014, 4:24 p.m.)
> 
> 
> Review request for KDE Multimedia, Christoph Feck and Christian Esken.
> 
> 
> Repository: kmix
> 
> 
> Description
> -------
> 
> Adjust popup widget layout. Device icons should no longer hit window border with some styles.
> 
> 
> Diffs
> -----
> 
>   gui/viewdockareapopup.cpp 64db6ac 
> 
> Diff: https://git.reviewboard.kde.org/r/121166/diff/
> 
> 
> Testing
> -------
> 
> This patch is used in ROSA and OpenMandriva since KDE 4.10.3.
> 
> 
> Thanks,
> 
> Andrey Bondrov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150120/50987dbb/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list