Review Request 122022: Phonon-vlc on mac fails to build because of one include path, this fixes it.

Harald Sitter sitter at kde.org
Tue Jan 13 08:15:24 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122022/#review73903
-----------------------------------------------------------

Ship it!


That would break it for Qt4 as there is no QtWidgets there ;)
Please remove the directory part altogether instead. Otherwise good to go. Thanks for fixing this <3

- Harald Sitter


On Jan. 12, 2015, 11:45 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122022/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 11:45 p.m.)
> 
> 
> Review request for Phonon, Phonon Backends and Harald Sitter.
> 
> 
> Repository: phonon-vlc
> 
> 
> Description
> -------
> 
> When building the phonon group with kdesrc-build on mac phono-vlc fails to build without this one change.
> 
> 
> Diffs
> -----
> 
>   src/video/mac/vlcmacwidget.h 85d649e 
> 
> Diff: https://git.reviewboard.kde.org/r/122022/diff/
> 
> 
> Testing
> -------
> 
> Phonon-vlc builds (though applications that try to use it crash with a QList assertion currently)
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150113/c16d1ed9/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list