Review Request 126554: Fix phonon-gst build on Gentoo with recent gstreamer-1.0
Daniel Vrátil
dvratil at kde.org
Thu Dec 31 08:12:33 GMT 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126554/#review90369
-----------------------------------------------------------
Ship it!
Ship It!
- Daniel Vrátil
On Dec. 31, 2015, 2:57 a.m., Michael Pyne wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126554/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2015, 2:57 a.m.)
>
>
> Review request for Phonon and Daniel Vrátil.
>
>
> Repository: phonon-gstreamer
>
>
> Description
> -------
>
> Advance the work started in RR #125690 to get phonon-gstreamer to find newer gstreamer-1.0 versions. I ended up having to add an additional check for gstreamer-1.0/include/gstconfig.h (perhaps that had been the intent of the original RR?).
>
>
> Diffs
> -----
>
> cmake/FindGStreamer.cmake e30c349
>
> Diff: https://git.reviewboard.kde.org/r/126554/diff/
>
>
> Testing
> -------
>
> Builds and works fine on Gentoo w/ gstreamer 1.6.2.
>
>
> Thanks,
>
> Michael Pyne
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20151231/7cea6033/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
More information about the kde-multimedia
mailing list