Review Request 126554: Fix phonon-gst build on Gentoo with recent gstreamer-1.0

Daniel Vrátil dvratil at kde.org
Wed Dec 30 11:00:18 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126554/#review90331
-----------------------------------------------------------



cmake/FindGStreamer.cmake (line 46)
<https://git.reviewboard.kde.org/r/126554/#comment61805>

    PATH_SUFFIXES can have more than one argument, so you could just add gstreamer-1.0/include here.


- Daniel Vrátil


On Dec. 28, 2015, 11:18 p.m., Michael Pyne wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126554/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 11:18 p.m.)
> 
> 
> Review request for Phonon and Daniel Vrátil.
> 
> 
> Repository: phonon-gstreamer
> 
> 
> Description
> -------
> 
> Advance the work started in RR #125690 to get phonon-gstreamer to find newer gstreamer-1.0 versions. I ended up having to add an additional check for gstreamer-1.0/include/gstconfig.h (perhaps that had been the intent of the original RR?).
> 
> 
> Diffs
> -----
> 
>   cmake/FindGStreamer.cmake e30c349 
> 
> Diff: https://git.reviewboard.kde.org/r/126554/diff/
> 
> 
> Testing
> -------
> 
> Builds and works fine on Gentoo w/ gstreamer 1.6.2.
> 
> 
> Thanks,
> 
> Michael Pyne
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20151230/81b07585/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list